Merged
Conversation
Adds 5 new logProxyCmd debug log calls to improve troubleshooting of the proxy subcommand: - Log proxy server creation parameters (guard path, policy presence, DIFC mode, trusted bot/user counts) before proxy.New - Log successful proxy server creation - Log HTTP server creation with TLS state - Log when TLS configuration is applied to the HTTP server - Log TLS trust environment setup (CA cert path and env vars being set) - Log successful TLS trust environment configuration These debug logs are controlled by DEBUG=cmd:proxy and write to both stderr (colorized, with time diffs) and the gateway log file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional debug-level logging to the awmg proxy subcommand to make proxy startup/TLS/trust-env setup easier to troubleshoot when DEBUG=cmd:proxy is enabled.
Changes:
- Log proxy server construction parameters and successful creation.
- Log HTTP server creation and when TLS config is applied.
- Log TLS trust environment configuration (entry + success).
Show a summary per file
| File | Description |
|---|---|
| internal/cmd/proxy.go | Adds several new logProxyCmd debug log lines around proxy/TLS setup and trust-env configuration. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+206
to
+207
| logProxyCmd.Printf("Creating proxy server: guard=%s, hasPolicy=%v, mode=%s, trustedBots=%d, trustedUsers=%d", | ||
| proxyGuardWasm, proxyPolicy != "", proxyDIFCMode, len(proxyTrustedBots), len(proxyTrustedUsers)) |
There was a problem hiding this comment.
PR description says this change adds 5 new logProxyCmd debug log calls, but this diff introduces 6 new calls (creating proxy server, created successfully, creating HTTP server, applying TLS config, configuring trust env, trust env configured). Please update the PR description/count to match the actual changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 5 new
logProxyCmddebug log calls tointernal/cmd/proxy.goto improve troubleshooting of theawmg proxysubcommand.Changes
internal/cmd/proxy.go— reuses the existinglogProxyCmd = logger.New("cmd:proxy")logger:proxy.New(guard path, policy presence, DIFC mode, trusted bot/user counts)configureTLSTrustEnvironment(CA cert path + env var names)Usage
Enable with
DEBUG=cmd:proxy ./awmg proxy ...orDEBUG=* ./awmg proxy ....Validation
go buildpasses (GOTOOLCHAIN=auto go1.25.0)go vet ./internal/cmd/...passesgofmtcleanTestFetchAndFixSchema_NetworkErrorfailure is unrelated to this change and reproducible onmainwithout my changes)Warning
The following domain was blocked by the firewall during workflow execution:
invalidhostthatdoesnotexist12345.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.